improve: apply tachyon optimizations(2 & 5)
#329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guorong009
changed the title
tachyon optimizations(2 & 5)
ed255
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Analyze and apply the
tachyonoptimizations - 2(batch normalize) & 5(save heap allocations)Related issues
Changes
batch_normalizein everywhere possible ofhalo2_backendcrateNOTE
batch_normalizeIn order to apply the
batch_normalizeoptimization, the algorithm ofbatch_normalize&batch_inverseshould be implemented for elliptic curves. It is already implemented in pse/halo2curves repo.save heap allocationsFor this optimization, I just apply one - remove unnecessary "clone" op in "permutation_commit".
The reason is that other optimizations needless in Rust project.
Also, the
Polynomialimplementation has big diff between projects.